Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable10] Test email verification with international email address - fixes #13586 #34759

Merged
merged 1 commit into from
Mar 13, 2019
Merged

[stable10] Test email verification with international email address - fixes #13586 #34759

merged 1 commit into from
Mar 13, 2019

Conversation

PVince81
Copy link
Contributor

Backport of #33207 to stable10

Now possible thanks to swiftmailer update in #34755

@PVince81 PVince81 added this to the development milestone Mar 13, 2019
@PVince81 PVince81 self-assigned this Mar 13, 2019
@PVince81 PVince81 mentioned this pull request Mar 13, 2019
Merged
9 tasks
phil-davis
phil-davis approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a bonus - on PHP 7.* those function return type declarations should work.

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #34759 into stable10 will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34759      +/-   ##
==============================================
+ Coverage       63.92%   64.19%   +0.27%     
  Complexity      19883    19883              
==============================================
  Files            1278     1278              
  Lines           76237    76237              
  Branches         1291     1291              
==============================================
+ Hits            48735    48942     +207     
+ Misses          27123    26916     -207     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <ø> (+0.3%) 19883 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Share/Share.php 71.2% <0%> (+0.06%) 507% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+0.48%) 68% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 93.75% <0%> (+1.04%) 34% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (+1.75%) 17% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.61% <0%> (+1.79%) 110% <0%> (ø) ⬇️
lib/private/AllConfig.php 94.52% <0%> (+2.05%) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 100% <0%> (+2.73%) 17% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 98.06% <0%> (+3.48%) 51% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 82.89% <0%> (+3.94%) 21% <0%> (ø) ⬇️
lib/private/DB/Adapter.php 88.88% <0%> (+6.17%) 25% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c146ac5...2669802. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #34759 into stable10 will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34759      +/-   ##
==============================================
+ Coverage       63.92%   64.19%   +0.27%     
  Complexity      19883    19883              
==============================================
  Files            1278     1278              
  Lines           76237    76237              
  Branches         1291     1291              
==============================================
+ Hits            48735    48942     +207     
+ Misses          27123    26916     -207     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <ø> (+0.3%) 19883 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Share/Share.php 71.2% <0%> (+0.06%) 507% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+0.48%) 68% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 93.75% <0%> (+1.04%) 34% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (+1.75%) 17% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.61% <0%> (+1.79%) 110% <0%> (ø) ⬇️
lib/private/AllConfig.php 94.52% <0%> (+2.05%) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 100% <0%> (+2.73%) 17% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 98.06% <0%> (+3.48%) 51% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 82.89% <0%> (+3.94%) 21% <0%> (ø) ⬇️
lib/private/DB/Adapter.php 88.88% <0%> (+6.17%) 25% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c146ac5...2669802. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 13, 2019 •
edited
Loading

Codecov Report

Merging #34759 into stable10 will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34759      +/-   ##
==============================================
+ Coverage       63.92%   64.19%   +0.27%     
  Complexity      19883    19883              
==============================================
  Files            1278     1278              
  Lines           76237    76237              
  Branches         1291     1291              
==============================================
+ Hits            48735    48942     +207     
+ Misses          27123    26916     -207     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <ø> (+0.3%) 19883 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Share/Share.php 71.2% <0%> (+0.06%) 507% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+0.48%) 68% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 93.75% <0%> (+1.04%) 34% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (+1.75%) 17% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.61% <0%> (+1.79%) 110% <0%> (ø) ⬇️
lib/private/AllConfig.php 94.52% <0%> (+2.05%) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 100% <0%> (+2.73%) 17% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 98.06% <0%> (+3.48%) 51% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 82.89% <0%> (+3.94%) 21% <0%> (ø) ⬇️
lib/private/DB/Adapter.php 88.88% <0%> (+6.17%) 25% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c146ac5...2669802. Read the comment docs.

@phil-davis phil-davis merged commit 1fe6a53 into stable10 Mar 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-test-email-verification-intl branch March 13, 2019 15:58
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
This was referenced Apr 15, 2019
Closed
Closed
@phil-davis phil-davis mentioned this pull request Jul 31, 2019
Merged
10 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@PVince81 PVince81

Labels
3 - To Review
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PVince81 @phil-davis @DeepDiver1975