detect correct uid when even wrong casing in given uid for files:scan

[karakayasemi]

Description

When doing a files:scan and entering the user id in the wrong case. The job tells, that no files are scanned. This PR fixes issue by learning correct uid from user manager. @pako81 since casing is not important in our uid policy, in my opinion this solution better than throwing an error. Do you think this PR is acceptable with this behavior?

Related Issue

• Fixes https://github.com/owncloud/enterprise/issues/3308

Motivation and Context

Solving bugs.

How Has This Been Tested?

• use files:scan command with wrong casing
• it should detect correct uid and work

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[pako81]

@karakayasemi yes, I do agree with you. Better getting the right uid instead of throwing an exception. thank you.

[codecov]

Codecov Report

Merging #35324 into master will decrease coverage by 16.66%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #35324       +/-   ##
=============================================
- Coverage     65.53%   48.87%   -16.67%     
=============================================
  Files          1218      109     -1109     
  Lines         70548    10560    -59988     
  Branches       1288     1288               
=============================================
- Hits          46235     5161    -41074     
+ Misses        23936     5022    -18914     
  Partials        377      377

Flag	Coverage Δ	Complexity Δ
#javascript	53.69% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	38.17% <ø> (-28.73%)	0 <ø> (-18648)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/DAV.php	59.45% <0%> (-21.64%)	0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1100 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7684118...d4bd6fe. Read the comment docs.

[codecov]

Codecov Report

Merging #35324 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #35324      +/-   ##
============================================
+ Coverage     65.53%   65.53%   +<.01%     
  Complexity    18648    18648              
============================================
  Files          1218     1218              
  Lines         70548    70549       +1     
  Branches       1288     1288              
============================================
+ Hits          46235    46236       +1     
  Misses        23936    23936              
  Partials        377      377

Flag	Coverage Δ	Complexity Δ
#javascript	53.69% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.89% <100%> (ø)	18648 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/files/lib/Command/Scan.php	71.91% <100%> (+0.09%)	74 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7684118...d4bd6fe. Read the comment docs.

[phil-davis]

I added backport-request because I guess this change is relevant in stable10 also.

[karakayasemi]

Backport PR: #35344