Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable10] Replay migrations on the created schema before copying data #35390

Merged
merged 3 commits into from
Jun 7, 2019

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented May 31, 2019

Backport of #30643

Ref #27075 (comment)
and some more fixes:

  • answer 'n' to the 'continue' question was ignored
  • added a new line after progressbar completion. Because this sucks:
oc_account_terms
    0 [>---------------------------]oc_accounts
 1/1 [============================] 100%oc_addressbookchanges

now it looks like this:

oc_account_terms
    0 [>---------------------------]
oc_accounts
 1/1 [============================] 100%
oc_addressbookchanges

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #35390 into stable10 will increase coverage by 0.04%.
The diff coverage is 37.09%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35390      +/-   ##
==============================================
+ Coverage       64.69%   64.73%   +0.04%     
- Complexity      20103    20199      +96     
==============================================
  Files            1293     1293              
  Lines           76977    77243     +266     
  Branches         1300     1300              
==============================================
+ Hits            49797    50005     +208     
- Misses          26796    26854      +58     
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.88% <37.09%> (+0.04%) 20199 <37> (+96) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/register_command.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_external/appinfo/app.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/Command/Db/ConvertType.php 38.27% <36.69%> (+38.27%) 56 <37> (+15) ⬆️
apps/systemtags/appinfo/app.php 14.28% <75%> (-0.35%) 0 <0> (ø)
apps/dav/lib/CalDAV/CalendarObject.php 94.11% <0%> (-2.66%) 18% <0%> (ø)
apps/dav/lib/DAV/Sharing/Plugin.php 68.29% <0%> (-0.94%) 14% <0%> (ø)
lib/private/Archive/TAR.php 86.33% <0%> (-0.9%) 66% <0%> (+10%)
apps/dav/lib/CardDAV/AddressBook.php 76.19% <0%> (-0.6%) 21% <0%> (ø)
apps/dav/lib/CalDAV/Calendar.php 85.47% <0%> (-0.38%) 48% <0%> (+4%)
lib/private/Memcache/ArrayCache.php 100% <0%> (ø) 19% <0%> (+2%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619572c...4034d9f. Read the comment docs.

@micbar
Copy link
Contributor

micbar commented May 31, 2019

@VicDeo Why do we have a different coverage than on master?

@VicDeo
Copy link
Member Author

VicDeo commented May 31, 2019

@micbar
no idea, I can't even say why

#javascript | 53.85% <ø> (?) | 0 <ø> (?) |  
#phpunit | 65.9% <37.09%> (+0.09%) | 20118 <37> (+18)

so #javascript is the same and #phpunit increased by +0.09% but it will decrease coverage by 1.06% according to #35390 (comment)

@VicDeo VicDeo force-pushed the stble10-fix-27075 branch 4 times, most recently from 9ca6a9c to 4034d9f Compare June 6, 2019 12:56
@micbar
Copy link
Contributor

micbar commented Jun 6, 2019

@VicDeo another random failure on CI

@VicDeo
Copy link
Member Author

VicDeo commented Jun 7, 2019

after several rebases it has been passed finally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants