Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable10] received shares must go into share_folder when configured #35396

Merged
merged 1 commit into from
May 31, 2019

Conversation

karakayasemi
Copy link
Contributor

Backport of #35312

Description

Federates shares currently does not respect to configured share folder. This PR resolves this bug.

Related Issue

Motivation and Context

Resolving bug.

How Has This Been Tested?

Manually by following below steps:
Scenario 1

  • install two ownCloud instance
  • add 'share_folder' => 'test' to config.php's of first instance
  • share a file from second instance to first instance
  • accept the share from first instance
  • the file should be in test folder

Scenario 2

  • install two ownCloud instance
  • add second instance as a trusted server in first instance
  • configure auto-accepting federated shares from trusted servers in first instance
  • add 'share_folder' => 'test' to config.php's of first instance
  • share a file from second instance to first instance
  • the file should be in test folder

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar added this to the development milestone May 31, 2019
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #35396 into stable10 will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35396      +/-   ##
==============================================
+ Coverage       64.65%   64.68%   +0.02%     
  Complexity      20103    20103              
==============================================
  Files            1293     1293              
  Lines           76974    76976       +2     
  Branches         1300     1300              
==============================================
+ Hits            49770    49793      +23     
+ Misses          26820    26799      -21     
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.83% <100%> (+0.03%) 20103 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/lib/External/Manager.php 90% <100%> (+12.61%) 32 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2016f...ea03c1a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #35396 into stable10 will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35396      +/-   ##
==============================================
+ Coverage       64.65%   64.68%   +0.02%     
  Complexity      20103    20103              
==============================================
  Files            1293     1293              
  Lines           76974    76976       +2     
  Branches         1300     1300              
==============================================
+ Hits            49770    49793      +23     
+ Misses          26820    26799      -21     
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.83% <100%> (+0.03%) 20103 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/lib/External/Manager.php 90% <100%> (+12.61%) 32 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2016f...ea03c1a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants