Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Webdav TrashBin API #35716

Merged

Conversation

DeepDiver1975
Copy link
Member

backport #35636

@DeepDiver1975 DeepDiver1975 self-assigned this Jul 1, 2019
@DeepDiver1975 DeepDiver1975 changed the title Stable10 d9cce0009ae5b39a4a39b9b3543f22b692474725 [stable10] Webdav TrashBin API Jul 1, 2019
@phil-davis phil-davis mentioned this pull request Jul 2, 2019
11 tasks
return $node->getDeleteTimestamp();
});

$propFind->handle(self::TRASHBIN_DELETE_DATETIME, static function () use ($node) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave out datetime. the delete timestamp by definition (= unix timestamp) is in the GMT timezone ... or at least should be. and everything I know can digest unix timestamps. we can add it, but should recommend using the timestamp.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unix timestamps will limit us to the interval of unix timestamps 01.01.1970-19.1.2038(int32 based)
Using a real date time format is not limited to this.

furthermore the timezone is fixed/not part of the transmission - using a real date time format can support this (even if not used as of today)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and as discussed: http://apiux.com/2013/03/20/5-laws-api-dates-and-times/ advised to use ISO-8601 - we use http://tools.ietf.org/html/rfc7231#section-7.1.1.1 to stay consistent with the getlastmodified property

Copy link
Member

@butonic butonic Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense ... nevertheless, unix timestamps are supposed to be GMT / UTC but that is just screaming for errors ;-)

@DeepDiver1975 DeepDiver1975 merged commit d704115 into stable10 Jul 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-d9cce0009ae5b39a4a39b9b3543f22b692474725 branch July 3, 2019 09:03
@davitol davitol mentioned this pull request Sep 3, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants