[stable10] Webdav TrashBin API#35716
Conversation
DeepDiver1975
changed the title
| return $node->getDeleteTimestamp(); | ||
| }); | ||
|
|
||
| $propFind->handle(self::TRASHBIN_DELETE_DATETIME, static function () use ($node) { |
There was a problem hiding this comment.
I think we can leave out datetime. the delete timestamp by definition (= unix timestamp) is in the GMT timezone ... or at least should be. and everything I know can digest unix timestamps. we can add it, but should recommend using the timestamp.
There was a problem hiding this comment.
unix timestamps will limit us to the interval of unix timestamps 01.01.1970-19.1.2038(int32 based)
Using a real date time format is not limited to this.
furthermore the timezone is fixed/not part of the transmission - using a real date time format can support this (even if not used as of today)
There was a problem hiding this comment.
and as discussed: http://apiux.com/2013/03/20/5-laws-api-dates-and-times/ advised to use ISO-8601 - we use http://tools.ietf.org/html/rfc7231#section-7.1.1.1 to stay consistent with the getlastmodified property
There was a problem hiding this comment.
that makes sense ... nevertheless, unix timestamps are supposed to be GMT / UTC but that is just screaming for errors ;-)
delete-merged-branch
bot
deleted the
stable10-d9cce0009ae5b39a4a39b9b3543f22b692474725
branch
5 participants
backport #35636