Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the width of the set password button #35813

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Conversation

ChrisEdS
Copy link
Contributor

Description

Limit the width of the set password button

Screenshots:

Before:
before

After:
after

Motivation and Context

Looks better.

How Has This Been Tested?

  • Manual tested in Firefox and Chrome

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #35813 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35813   +/-   ##
=========================================
  Coverage     65.81%   65.81%           
  Complexity    18819    18819           
=========================================
  Files          1228     1228           
  Lines         70983    70983           
  Branches       1289     1289           
=========================================
  Hits          46717    46717           
  Misses        23888    23888           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.19% <ø> (ø) 18819 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f30af9...915f70f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #35813 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35813   +/-   ##
=========================================
  Coverage     65.81%   65.81%           
  Complexity    18819    18819           
=========================================
  Files          1228     1228           
  Lines         70983    70983           
  Branches       1289     1289           
=========================================
  Hits          46717    46717           
  Misses        23888    23888           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.19% <ø> (ø) 18819 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f30af9...915f70f. Read the comment docs.

@ChrisEdS ChrisEdS requested a review from LukasHirt July 16, 2019 14:58
@ChrisEdS ChrisEdS merged commit dd46e3e into master Jul 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-set-email-button branch July 18, 2019 13:00
@phil-davis
Copy link
Contributor

Backport stable10 #35878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants