Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case phoenix is configured to be used with this instance - private… #35819

Merged
merged 1 commit into from Jul 17, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jul 12, 2019

… links are redirected

Description

private links will be redirected to phoenix if configured

Related Issue

How Has This Been Tested?

  • add config 'phoenix.baseUrl' => 'http://172.17.0.1:8300'
  • open a private link in the browser
  • see it being redirected to phoenix

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #35819 into stable10 will decrease coverage by <.01%.
The diff coverage is 39.28%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35819      +/-   ##
==============================================
- Coverage       65.09%   65.08%   -0.01%     
- Complexity      20239    20246       +7     
==============================================
  Files            1300     1301       +1     
  Lines           77238    77266      +28     
  Branches         1301     1301              
==============================================
+ Hits            50279    50290      +11     
- Misses          26574    26591      +17     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.27% <39.28%> (-0.02%) 20246 <7> (+7)
Impacted Files Coverage Δ Complexity Δ
core/routes.php 55.88% <0%> (-9.64%) 0 <0> (ø)
apps/dav/lib/Server.php 53.42% <100%> (+0.97%) 24 <0> (ø) ⬇️
apps/dav/lib/Meta/MetaPlugin.php 40% <40%> (ø) 7 <7> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50df15a...c2180ae. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #35819 into stable10 will decrease coverage by 0.88%.
The diff coverage is 39.28%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35819      +/-   ##
==============================================
- Coverage       65.97%   65.08%   -0.89%     
- Complexity      20245    20246       +1     
==============================================
  Files            1238     1301      +63     
  Lines           69875    77266    +7391     
  Branches            0     1301    +1301     
==============================================
+ Hits            46101    50290    +4189     
- Misses          23774    26591    +2817     
- Partials            0      385     +385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 66.27% <39.28%> (+0.29%) 20246 <7> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/routes.php 55.88% <0%> (-9.64%) 0 <0> (ø)
apps/dav/lib/Server.php 53.42% <100%> (+0.97%) 24 <0> (ø) ⬇️
apps/dav/lib/Meta/MetaPlugin.php 40% <40%> (ø) 7 <7> (?)
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.91% <0%> (-9.17%) 74% <0%> (ø)
apps/dav/appinfo/v1/publicwebdav.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
...s/dav/lib/Files/Sharing/PublicLinkEventsPlugin.php
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10d729c...fe55a78. Read the comment docs.

@DeepDiver1975 DeepDiver1975 force-pushed the feature/link-redirectin-to-phoenix branch from c2180ae to fe55a78 Compare July 15, 2019 11:03
@DeepDiver1975 DeepDiver1975 force-pushed the feature/link-redirectin-to-phoenix branch from fe55a78 to 02d73bc Compare July 16, 2019 09:17
@DeepDiver1975 DeepDiver1975 merged commit fea03ca into stable10 Jul 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/link-redirectin-to-phoenix branch July 17, 2019 09:48
@phil-davis
Copy link
Contributor

stable10 and master are still living on at the moment. So I added only-in-stable10 label here so that it will be easier to find PRs that have only been applied to stable10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants