[For 10.4] Support Oracle connect string#36489
Merged
Merged
Conversation
7bc40c9 to
71ff27e
Compare
Codecov Report
@@ Coverage Diff @@
## master #36489 +/- ##
============================================
+ Coverage 64.68% 64.68% +<.01%
- Complexity 19023 19024 +1
============================================
Files 1268 1268
Lines 74362 74367 +5
Branches 1309 1309
============================================
+ Hits 48100 48104 +4
- Misses 25876 25877 +1
Partials 386 386
Continue to review full report at Codecov.
|
Contributor
|
@DeepDiver1975 @settermjd needs documentation? |
12 tasks
Contributor
|
Existing CI demonstrates at least that ordinary Oracle database install has not been broken ;) |
Member
Author
|
It is not the reaponsibility of our testing setup to test oracles failover capabilities. I so assume this works 🤗 This pr allows the necessary setups of the Database connection in owncloud. |
71ff27e to
e9e1443
Compare
micbar
approved these changes
Dec 2, 2019
settermjd
added a commit
to owncloud/docs
that referenced
this pull request
Dec 2, 2019
This fixes #2127 and relates to owncloud/core#36489.
39 tasks
settermjd
added a commit
to owncloud/docs
that referenced
this pull request
Jan 10, 2020
This fixes #2127 and relates to owncloud/core#36489.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #35413
Description
Some failover/HA configurations in the Oracle world require support of connect strings.
Examples can be found here: https://docs.oracle.com/database/121/HABPT/config_fcf.htm#HABPT5391
This PR adds installation and operations using a new database config parameter: dbconnectionstring in config.php
Motivation and Context
Support Oracle HA/Failover scenarios
How Has This Been Tested?
Types of changes
Checklist: