[For 10.4] Add validation for sender email address

[pako81]

Description

This PR adds validation for the sender e-mail address when using the e-mail notification mechanism for public links as well as internal shares.

Motivation and Context

Given the following scenarios:

Scenario 1:

• User1 shares a folder with User2
• User1 does not have an e-mail address (NULL set in oc_accounts table)
• User2 has a valid e-mail address
• User1 clicks on the notify by email button: an error appears and the user cannot be notified

Scenario 2:

User1 (who does not have an email address) creates a brand new file or folder, creates a public link out of it and clicks on the Send link via email button in order to notify an external user. Also, in this case, the same error as above is returned.

How Has This Been Tested?

Manually by testing the two scenarios above and make sure no error is returned and e-mail is correctly delivered.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised
• Changelog item

[pako81]

@owncloud/qa would be good to have this covered by tests.

[phil-davis]

code style is failing, looks like indent issues - see https://drone.owncloud.com/owncloud/core/21653/2/6
do:

make test-php-style-fix

[phil-davis]

@micbar if you think this can get into 10.4 then please add to the 10.4.0 project and we can add some acceptance tests this week.

[micbar]

@phil-davis Done.

[phil-davis]

@haribhandari07 please assign someone to write some relevant acceptance test scenarios

[codecov]

Codecov Report

Merging #36505 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master   #36505      +/-   ##
============================================
+ Coverage     64.66%   64.66%   +<.01%     
- Complexity    19023    19025       +2     
============================================
  Files          1268     1268              
  Lines         74393    74398       +5     
  Branches       1311     1311              
============================================
+ Hits          48104    48108       +4     
- Misses        25903    25904       +1     
  Partials        386      386

Flag	Coverage Δ	Complexity Δ
#javascript	54.02% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.84% <85.71%> (ø)	19025 <2> (+2)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Share/MailNotifications.php	96.19% <85.71%> (-0.46%)	33 <2> (+2)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 471637d...aa63dc0. Read the comment docs.

[micbar]

@pako81 Can you add a changelog file
https://github.com/owncloud/core/blob/master/changelog/TEMPLATE
https://github.com/owncloud/core/blob/master/changelog/README.md

[phil-davis]

https://drone.owncloud.com/owncloud/core/21690/3/7

------ ----------------------------------------- 
  Line   lib/private/Share/MailNotifications.php  
 ------ ----------------------------------------- 
  186    Undefined variable: $senderMailAdress    
  267    Undefined variable: $senderMailAdress    
 ------ ----------------------------------------- 

 [ERROR] Found 2 errors                                                         

[phil-davis]

@haribhandari07 please be careful adding a commit with tests. This branch is still being force-pushed so it will be easy for your commit/code to get lost. Maybe work in a branch on top of this.

[phil-davis]

@pako81 the acceptance tests added by @haribhandari07 have disappeared with your force push.
We need to first pull whatever is on GitHub, then make changes and push.

@haribhandari07 please find your local commit with the tests and add it again to this PR.

[karakayasemi]

Code looks good.

[phil-davis]

I will squash the commits.

[pako81]

thanks @phil-davis @micbar @karakayasemi @haribhandari07 !