-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "+" character in usernames #36613
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36613 +/- ##
============================================
+ Coverage 64.67% 64.68% +<.01%
Complexity 19099 19099
============================================
Files 1268 1268
Lines 74695 74695
Branches 1320 1320
============================================
+ Hits 48309 48315 +6
+ Misses 25998 25992 -6
Partials 388 388
Continue to review full report at Codecov.
|
28d5e5b
to
6a66a22
Compare
6a66a22
to
3ad2baf
Compare
thanks a lot @phil-davis :) |
@phil-davis I was now thinking about the user provisioning APIs. In there, the |
@pako81 I added provisioning API tests. They are passing locally for me and I expect that they will pass in drone CI. |
@phil-davis correct, I was testing the wrong way. The following seems to work correctly.
User |
f2129d4
to
cb91305
Compare
There have been other major features merged just now. So I rebased this PR to make sure that the CI is all green on top of those changes now in master. |
@micbar @HanaGemela I have added acceptance test coverage and it passes (adding users with I some developer can review the code and approve, and you think this is a change/enhancement that we should have, then feel free to merge it for 10.4 |
cb91305
to
8be87ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems good. As a last, this should be adjusted also.
core/core/Command/User/Add.php
Line 67 in 98922f1
'User ID used to login (must only contain a-z, A-Z, 0-9, -, _ and @).' |
thanks @karakayasemi :) missed that |
7c34029
to
80807c2
Compare
Description
Allow
+
character when creating users.Related Issue
Motivation and Context
This PR allows the
+
character in the username when creating new users. This is also required when sharing with guest users having i.e. the following formatname+2@test.com
.How Has This Been Tested?
Manually by creating new users having the
+
sign in their usernames over the Users management page as well by using theuser:add
occ command.Types of changes
Checklist: