Remove part files when upload is cancelled for all public links#36761
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
sharidas
force-pushed
the
remove-partfiles
branch
from
b649ae9 to
1365974
Compare
|
Code looks good to me. We need to check the CI. In addition, check if it's easy to include an unittest for the change |
|
changelog needs an issue or PR link: until that is fixed, the "real" CI is not going to run |
sharidas
force-pushed
the
remove-partfiles
branch
2 times, most recently
from
6463283 to
31a9e75
Compare
sharidas
force-pushed
the
remove-partfiles
branch
from
31a9e75 to
776a2dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #36761 +/- ##
=========================================
Coverage 64.68% 64.68%
- Complexity 19120 19121 +1
=========================================
Files 1269 1269
Lines 74778 74778
Branches 1320 1320
=========================================
Hits 48372 48372
Misses 26018 26018
Partials 388 388
Continue to review full report at Codecov.
|
|
|
||
| public function testUnlinkPartFiles() { | ||
| $file = 'foo.txt.part'; | ||
| $storage = $this->getMaskedStorage(Constants::PERMISSION_ALL - Constants::PERMISSION_UPDATE); |
There was a problem hiding this comment.
we should check without delete permission
Remove the part files when upload is cancelled for the public links. Signed-off-by: Sujith H <sharidasan@owncloud.com>
sharidas
force-pushed
the
remove-partfiles
branch
from
776a2dd to
aea03bd
Compare
3 participants
Remove the part files when upload is cancelled for
the public links.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
When user tries to upload files to public links with
Upload OnlyorDownload / View / Uploadand cancels when the files are uploaded:Then it is noticed that the part files are not cleaned up properly.
So this change would help to clean up the part files even though the upload is cancelled for the public links.
Related Issue
Motivation and Context
This change set helps to clean up the part files when the uplaod is cancelled for the public links.
How Has This Been Tested?
Upload OnlyDownload / View / UploadScreenshots (if appropriate):
Types of changes
Checklist: