Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the same mtime as in the ownCloud's FS for files inside #37222

Merged
merged 2 commits into from
Apr 22, 2020

Conversation

jvillafanez
Copy link
Member

Description

Keep the mtime of the files and folders inside the downloaded tarball

Related Issue

https://github.com/owncloud/enterprise/issues/3939

Motivation and Context

How Has This Been Tested?

Manually tested both in mac and linux. Both the tar and zip files keeps the mtime of the files.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Apr 7, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #37222 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37222      +/-   ##
============================================
- Coverage     64.87%   64.87%   -0.01%     
- Complexity    19146    19147       +1     
============================================
  Files          1269     1269              
  Lines         74947    74957      +10     
  Branches       1331     1331              
============================================
+ Hits          48625    48626       +1     
- Misses        25930    25939       +9     
  Partials        392      392              
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.06% <0.00%> (-0.01%) 19147.00 <3.00> (+1.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Streamer.php 0.00% <0.00%> (ø) 13.00 <3.00> (ø)
lib/private/legacy/files.php 0.00% <0.00%> (ø) 67.00 <0.00> (ø)
...les_sharing/lib/Controller/RemoteOcsController.php 95.31% <0.00%> (+0.07%) 17.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 933efcf...97fed6d. Read the comment docs.

@micbar micbar requested a review from VicDeo April 20, 2020 08:16
@DeepDiver1975 DeepDiver1975 merged commit 7d0f44c into master Apr 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the tarzip_streamer_mtime branch April 22, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants