Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add values to the invalid uids list #37766

Merged
merged 1 commit into from
Aug 4, 2020
Merged

add values to the invalid uids list #37766

merged 1 commit into from
Aug 4, 2020

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Aug 3, 2020

Description

Added .htaccess, .ocdata, owncloud.db and owncloud.log to the invalid uids list.

Related Issue

Motivation and Context

Fixes issues caused by creating users with reserved names. Like the PR #37268

How Has This Been Tested?

  • tested locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Signed-off-by: David Christofas <dchristofas@owncloud.com>
@C0rby C0rby requested a review from phil-davis August 3, 2020 11:41
@C0rby C0rby self-assigned this Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #37766 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37766   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19388    19388           
=========================================
  Files          1283     1283           
  Lines         75746    75746           
  Branches       1333     1333           
=========================================
  Hits          49020    49020           
  Misses        26334    26334           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.89% <ø> (ø) 19388.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/private/User/Manager.php 86.41% <ø> (ø) 58.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 077934c...a86b925. Read the comment docs.

@phil-davis phil-davis requested a review from micbar August 3, 2020 13:51
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments #37765 (comment)
But IMO it will do more good to ban these than to try to allow them under special circumstances.

@micbar please get the appropriate people to review and comment.

@C0rby C0rby merged commit ab9f820 into master Aug 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the add-invalid-userids branch August 4, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add invalid uids
3 participants