add values to the invalid uids list#37766
Merged
Merged
Conversation
Signed-off-by: David Christofas <dchristofas@owncloud.com>
Codecov Report
@@ Coverage Diff @@
## master #37766 +/- ##
=========================================
Coverage 64.71% 64.71%
Complexity 19388 19388
=========================================
Files 1283 1283
Lines 75746 75746
Branches 1333 1333
=========================================
Hits 49020 49020
Misses 26334 26334
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
phil-davis
reviewed
Aug 3, 2020
Contributor
phil-davis
left a comment
There was a problem hiding this comment.
I made some comments #37765 (comment)
But IMO it will do more good to ban these than to try to allow them under special circumstances.
@micbar please get the appropriate people to review and comment.
micbar
approved these changes
Aug 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
.htaccess,.ocdata,owncloud.dbandowncloud.logto the invalid uids list.Related Issue
Motivation and Context
Fixes issues caused by creating users with reserved names. Like the PR #37268
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: