Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the log level for locked exceptions #37907

Merged
merged 4 commits into from
Sep 29, 2020

Conversation

jvillafanez
Copy link
Member

Description

Reduce the log level of locked exceptions to debug instead of fatal.

Related Issue

https://github.com/owncloud/enterprise/issues/4184

Motivation and Context

Locked exceptions could happen naturally if the file is effectively locked. This is normal behaviour, and as such, it shouldn't cause fatal exceptions. We'll use a debug log instead in order to track possible problems.

How Has This Been Tested?

  1. Manually lock a file
  2. Try to upload a new version of the file

A locked exception is shown with a debug log level.
The same happens if the folder is locked and you try to upload a new file inside.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #37907 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37907      +/-   ##
============================================
- Coverage     64.71%   64.71%   -0.01%     
- Complexity    19442    19444       +2     
============================================
  Files          1286     1286              
  Lines         76019    76021       +2     
  Branches       1336     1336              
============================================
+ Hits          49196    49197       +1     
- Misses        26429    26430       +1     
  Partials        394      394              
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <ø> (-0.01%) 19444.00 <ø> (+2.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../dav/lib/Connector/Sabre/ExceptionLoggerPlugin.php 96.42% <ø> (ø) 9.00 <0.00> (ø)
lib/private/Log.php 82.03% <ø> (-0.14%) 49.00 <0.00> (ø)
lib/private/User/SyncService.php 82.85% <0.00%> (-0.29%) 63.00% <0.00%> (+2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce56429...4decd46. Read the comment docs.

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog, rest looks fine

@phil-davis
Copy link
Contributor

Rebased to get good CI.

@phil-davis phil-davis merged commit 38ffc66 into master Sep 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the reduce_locked_exception_level branch September 29, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants