Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new defaults for the icon and label of the phoenix menu item #37923

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 21, 2020

Description

When phoenix is configured (phoenix.baseUrl in config.php), the app switcher has a menu item for Phoenix. This now has a new and configurable default icon and default label, as discussed and decided by the design initiative last week.

Open question: Is it relevant to have translations for the menu item label?

Related Issue

Motivation and Context

Make it easier for users to spot the switch to the new design.

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot 2020-09-21 at 14 29 11

Screenshot 2020-09-21 at 14 29 24

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@kulmann kulmann added this to the development milestone Sep 21, 2020
@kulmann kulmann self-assigned this Sep 21, 2020
@CLAassistant
Copy link

CLAassistant commented Sep 21, 2020

CLA assistant check
All committers have signed the CLA.

@pmaier1
Copy link
Contributor

pmaier1 commented Sep 21, 2020

Nice work, thanks!

Open question: Is it relevant to have translations for the menu item label?

Yes, please!

When phoenix is configured (phoenix.baseUrl in config.php), the app
switcher has a menu item for Phoenix. This now has a new and
configurable default icon and default label.
lib/private/NavigationManager.php Outdated Show resolved Hide resolved
@kulmann
Copy link
Member Author

kulmann commented Sep 22, 2020

@micbar codecov results are missing...

@phil-davis
Copy link
Contributor

codecov results are almost always missing in core. I had a support ticket about that - https://codecov.freshdesk.com/support/tickets/3634 - but no joy yet. Some days the results get posted back to GitHub, some days not.

@owncloud owncloud deleted a comment from update-docs bot Sep 22, 2020
@kulmann
Copy link
Member Author

kulmann commented Sep 22, 2020

Ah, ok. Thanks for explaining @phil-davis :-)

@micbar micbar merged commit 1b14b28 into master Sep 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the phoenix-default-menu-item branch September 22, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate Switch between classic frontend and ocis-web
6 participants