-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
with user sync command error properly exit and log #37951
Conversation
5db8801
to
aa0c71d
Compare
Codecov Report
@@ Coverage Diff @@
## master #37951 +/- ##
============================================
- Coverage 64.71% 64.71% -0.01%
- Complexity 19442 19445 +3
============================================
Files 1286 1286
Lines 76019 76034 +15
Branches 1336 1336
============================================
+ Hits 49196 49203 +7
- Misses 26429 26437 +8
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aa0c71d
to
bd37609
Compare
Needs a rebase - https://drone.owncloud.com/owncloud/core/27168/97/18 |
bd37609
to
54d8539
Compare
337d526
to
ccd6d99
Compare
@jvillafanez could you have a look after review fixes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of little optional details, but approving anyway.
should go in 10.6 |
ccd6d99
to
225eaa3
Compare
225eaa3
to
d9903d8
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
When running
./occ user:sync
make sure to exit on error with non-zero, plus add log to console informing on errorRelated: https://github.com/owncloud/enterprise/issues/4218