Skip to content

with user sync command error properly exit and log#37951

Merged
phil-davis merged 1 commit into
masterfrom
bugfix/user-sync-errors
Oct 19, 2020
Merged

with user sync command error properly exit and log#37951
phil-davis merged 1 commit into
masterfrom
bugfix/user-sync-errors

Conversation

@mrow4a
Copy link
Copy Markdown
Contributor

@mrow4a mrow4a commented Sep 27, 2020 •
edited
Loading

When running ./occ user:sync make sure to exit on error with non-zero, plus add log to console informing on error

  • add tests
  • add changelog

Related: https://github.com/owncloud/enterprise/issues/4218

@mrow4a mrow4a self-assigned this Sep 27, 2020
@mrow4a mrow4a force-pushed the bugfix/user-sync-errors branch from 5db8801 to aa0c71d Compare September 28, 2020 17:21
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 28, 2020 •
edited
Loading

Codecov Report

Merging #37951 into master will decrease coverage by 0.00%.
The diff coverage is 59.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37951      +/-   ##
============================================
- Coverage     64.71%   64.71%   -0.01%     
- Complexity    19442    19445       +3     
============================================
  Files          1286     1286              
  Lines         76019    76034      +15     
  Branches       1336     1336              
============================================
+ Hits          49196    49203       +7     
- Misses        26429    26437       +8     
  Partials        394      394
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <59.09%> (-0.01%) 19445.00 <0.00> (+3.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
core/Command/User/SyncBackend.php 75.57% <55.55%> (-2.26%) 41.00 <0.00> (+3.00) ⬇️
lib/private/User/SyncService.php 83.23% <75.00%> (+0.09%) 61.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce56429...bd37609. Read the comment docs.

@mrow4a mrow4a force-pushed the bugfix/user-sync-errors branch from aa0c71d to bd37609 Compare October 7, 2020 18:43
@mrow4a mrow4a requested a review from jvillafanez October 7, 2020 18:44
@owncloud owncloud deleted a comment from update-docs Bot Oct 8, 2020
@phil-davis
Copy link
Copy Markdown
Contributor

phil-davis commented Oct 8, 2020

Needs a rebase - https://drone.owncloud.com/owncloud/core/27168/97/18
The API acceptance test suites have been split up a few days ago. Somehow the force-push 8 hours ago was not to a current master.

jvillafanez
jvillafanez reviewed Oct 8, 2020
View reviewed changes
Comment thread core/Command/User/SyncBackend.php Outdated
Comment thread core/Command/User/SyncBackend.php Outdated
Comment thread core/Command/User/SyncBackend.php Outdated
Comment thread core/Command/User/SyncBackend.php Outdated
Comment thread lib/private/User/SyncService.php Outdated
@mrow4a mrow4a force-pushed the bugfix/user-sync-errors branch from bd37609 to 54d8539 Compare October 9, 2020 09:41
@mrow4a mrow4a requested a review from jvillafanez October 9, 2020 09:42
@mrow4a mrow4a force-pushed the bugfix/user-sync-errors branch 2 times, most recently from 337d526 to ccd6d99 Compare October 9, 2020 11:02
@mrow4a
Copy link
Copy Markdown
Contributor Author

mrow4a commented Oct 9, 2020

@jvillafanez could you have a look after review fixes?

jvillafanez
jvillafanez approved these changes Oct 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jvillafanez jvillafanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of little optional details, but approving anyway.

Comment thread core/Command/User/SyncBackend.php Outdated
Comment thread core/Command/User/SyncBackend.php Outdated
Comment thread core/Command/User/SyncBackend.php Outdated
Comment thread core/Command/User/SyncBackend.php Outdated
@micbar
Copy link
Copy Markdown
Contributor

micbar commented Oct 12, 2020

should go in 10.6

@mrow4a mrow4a force-pushed the bugfix/user-sync-errors branch from ccd6d99 to 225eaa3 Compare October 13, 2020 17:04
@mrow4a mrow4a force-pushed the bugfix/user-sync-errors branch from 225eaa3 to d9903d8 Compare October 13, 2020 17:18
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mrow4a mrow4a requested a review from jvillafanez October 13, 2020 18:23
@phil-davis phil-davis merged commit f5188a1 into master Oct 19, 2020
@delete-merged-branch delete-merged-branch Bot deleted the bugfix/user-sync-errors branch October 19, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@cdamken cdamken Awaiting requested review from cdamken

+1 more reviewer

@karakayasemi karakayasemi karakayasemi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrow4a mrow4a

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrow4a @phil-davis @micbar @jvillafanez @karakayasemi