Skip to content

Conversation

@jvillafanez
Copy link
Member

Description

Set a minimum height for the sharee list so the icons are properly "floated" to the right

Related Issue

https://github.com/owncloud/enterprise/issues/4221

Motivation and Context

How Has This Been Tested?

Seen after the avatars were disabled

Screenshots (if appropriate):

Screenshot from 2020-10-01 14-49-01

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Oct 1, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #37964 into master will increase coverage by 0.00%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37964   +/-   ##
=========================================
  Coverage     64.71%   64.72%           
- Complexity    19444    19445    +1     
=========================================
  Files          1286     1286           
  Lines         76021    76038   +17     
  Branches       1336     1336           
=========================================
+ Hits          49197    49214   +17     
  Misses        26430    26430           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.07% <100.00%> (+<0.01%) 0.00 <0.00> (ø)
#phpunit 65.89% <94.44%> (+<0.01%) 19445.00 <1.00> (+1.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
core/register_command.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
core/Command/Encryption/Disable.php 100.00% <100.00%> (ø) 5.00 <1.00> (+1.00)
core/js/sharedialogshareelistview.js 72.15% <100.00%> (+0.15%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e27a6ba...2603fae. Read the comment docs.

@jvillafanez jvillafanez force-pushed the share_icons_aligment branch from 2b79f68 to 01e20dd Compare October 2, 2020 08:26
@jvillafanez
Copy link
Member Author

Screenshot from 2020-10-02 10-28-01

It looks a bit better now. There is a bit of space taken by the margin of the hidden avatar, but I think it's ok.
The problem with long names was present before and might need bigger changes.

@jvillafanez jvillafanez force-pushed the share_icons_aligment branch from 2603fae to fbb48b2 Compare October 9, 2020 06:43
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@micbar micbar merged commit 1b5c865 into master Oct 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the share_icons_aligment branch October 12, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants