Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle StorageNotAvailableException in share external #38042

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Oct 27, 2020

This fixes following problems when federates share storage is unavailable:

  • now we can see the share in "Shared with me"
  • list the files structure that has been available before storage got unavailable.
  • unshare the share
  • check share info

Additionaly, warning is properly displayed

Zrzut ekranu 2020-10-27 o 21 25 49

Zrzut ekranu 2020-10-27 o 21 25 19

@update-docs
Copy link

update-docs bot commented Oct 27, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@mrow4a mrow4a self-assigned this Oct 27, 2020
@mrow4a mrow4a force-pushed the bugfix/handle-fed-share-storage-not-available branch from 935174f to 2dc529a Compare October 27, 2020 20:54
Copy link
Member

@jvillafanez jvillafanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo to fix, but the code looks good

Co-authored-by: Phil Davis <phil@jankaritech.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 22f459b into master Oct 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/handle-fed-share-storage-not-available branch October 28, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants