Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getSharesInDir method and allow new interaction in params #38053

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

jvillafanez
Copy link
Member

@jvillafanez jvillafanez commented Oct 29, 2020

"subfiles" param in the getShares request can interact with "reshares"
and the new "share_types" params. The "path" param is still required if
"subfiles" is present.
There are no changes regarding the "shared_with_me" param

Description

The "subfiles" parameter in the getShares request had some additional restrictions which weren't documented. This PR remove those restrictions and allows interaction with the rest of the parameters (except the "share_with_me", which remain the same

Related Issue

No opened issue.
Follow up of #38000

Motivation and Context

there is no reason to limit the interaction of the "reshares" and "share_types" parameters with the "subfiles" one.

How Has This Been Tested?

Checked manually via API

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

"subfiles" param in the getShares request can interact with "reshares"
and the new "share_types" params. The "path" param is still required if
"subfiles" is present.
There are no changes regarding the "shared_with_me" param
@update-docs
Copy link

update-docs bot commented Oct 29, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@karakayasemi karakayasemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I see, the consumer of getSharesIndir already makes all the checks that getSharesIndir has. So, removing it makes sense to me.

@karakayasemi karakayasemi merged commit 7792b5a into master Nov 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the getshare_params branch November 7, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants