Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the scrollbar on the right darker and wider in favor of beeing more visual present #38183

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Make the scrollbar on the right darker and wider in favor of beeing more visual present #38183

merged 3 commits into from
Dec 2, 2020

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Dec 2, 2020 •
edited
Loading

Description

Make the scrollbar on the right darker and wider in favor of beeing more visual present

Related Issue

Screenshots (if appropriate):

Before

Screenshot_20201202_112832

After

Screenshot_20201202_114423

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear self-assigned this Dec 2, 2020
@mmattel @phil-davis
Update changelog/unreleased/38183
ae0475a 
Co-authored-by: Phil Davis <phil@jankaritech.com>
@owncloud owncloud deleted a comment from update-docs bot Dec 2, 2020
@phil-davis phil-davis self-requested a review December 2, 2020 11:54
phil-davis
phil-davis approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Do we have a "visual UI" person who can give their opinion about how scrollbars should look these days?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlexAndBear AlexAndBear merged commit 9a02971 into master Dec 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the issues/38182 branch December 2, 2020 13:19
@jnweiger
Copy link
Contributor

Confirmed fixed for google-chrome in 10.7.0RC1
Firefox always had nice scrollbars, but in chrome 10.6.0 had the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@AlexAndBear AlexAndBear

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrollbar hard to see
4 participants
@AlexAndBear @jnweiger @phil-davis @mmattel