Catch StorageNotAvailableException while formatting the share #38190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getById method called while formatting could go down to the storage if somehow the node needs to be updated. If so, the storage where the node is could not be available, causing the exception to pop up. Such exception causes the list of shares to be broken since it wasn't being caught.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Works with Damken-Cloud! |
karakayasemi
previously approved these changes
Dec 3, 2020
|
We need changelog entry before merge. |
|
I assume we don't need to rush so this will be in 10.7. I haven't been able to reproduce the scenario locally, so maybe the conditions to reach the issue cannot happen in the recent versions. |
jvillafanez
force-pushed
the
notavailable_while_formatting
branch
from
f38688c to
fc3eaea
Compare
|
Added changelog item |
karakayasemi
approved these changes
Dec 4, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getById method called while formatting could go down to the storage
if somehow the node needs to be updated. If so, the storage where the
node is could not be available, causing the exception to pop up.
Such exception causes the list of shares to be broken since it wasn't
being caught.
Description
Catch a possible StorageNotAvailableException that could be thrown while formatting the shares.
This specially affects to the share listing, which could be broken and the UI might not show any local share if such exception happens.
So far, this has been detected only while listing the shares, and the steps to reproduce aren't fully clear. There are some other locations for the
formatSharemethod being called, although it's expected to behave better since other similar exception that could happen such asNotFoundExceptionaren't being handled in those places.Related Issue
Related to https://github.com/owncloud/enterprise/issues/4250
Motivation and Context
Could lead to an empty list of shares
How Has This Been Tested?
Not tested yet
Screenshots (if appropriate):
Types of changes
Checklist: