-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UI success/error while adding storages #38288
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
57bdbc5
to
cd3c975
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A typo in the changelog text. Sad to have to run all that CI again just for this.
Co-authored-by: Phil Davis <phil@jankaritech.com>
Can be merged after tech demo |
Kudos, SonarCloud Quality Gate passed! |
I see a potential problem. Let's assume the following setup:
Normally, the connectivity check is done using the admin account. If the admin cannot access to the external storage, we assume there is a problem with the setup. However, in the setup above, the problem is that there is no admin in the AD. Using a valid AD account instead of the ownCloud's admin would show a green light instead. I'm a bit worried that the error message will make more noise even though the setup itself could be fine. A softer message could be better, such as "The current ownCloud's user (in case there are multiple admins) can't access to the external storage. In some scenarios, this could be ok, but please, recheck the configuration" |
@jvillafanez Edgy case but a good objection, maybe we could show this 'soften message' only if there is an error with the SMB/WND configuration? |
Technically, it can happen with any storage. I guess the setup above is kind of expected for SMB/WND, so this flaw is more visible there. |
@pmaier1 @cdamken @hodyroff @micbar |
@jvillafanez as discussed with PM we will still show this message but enter a hint in the docs |
@janackermann Please create a docs issue, else this will be gone and lost |
Description
Related Issue
Motivation and Context
Types of changes
Checklist: