Expose non-generic messages for 403 HTTP status to the end user #38416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
8b2ebe2#diff-5f714a00dd14764258a4e4a95b600644974f29a1046a61a7cecd40f96337163d
Introduces a regression: all messages that are coming from 3rd-party apps (files_antivirus, firewall, etc) are masked with a generic message for HTTP status 403
Related Issue
https://github.com/owncloud/enterprise/issues/4418
owncloud/files_antivirus#395
Motivation and Context
The real reason why the file hasn't been uploaded is misreported
How Has This Been Tested?
Expected
Web UI reports that file is infected with EICAR
Actual
Web UI reports that user has no upload permission
Types of changes
Checklist: