-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add value userType to sharees api #38440
Conversation
1e4bd77
to
3d3613b
Compare
3d3613b
to
6402ded
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can api return „userType” instead? is this possible? this would make it more generic
Of course, we can do this, are there more types than 'user' and 'guest'? |
needs to be investigated, best if returns some ID / CONST defined in core. |
@mrow4a ok updated in that favor, might have quick look? if you give me green light, I will update the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally makes sense, one small detail to be fixed
45e26be
to
77851a3
Compare
77851a3
to
eb979cf
Compare
Kudos, SonarCloud Quality Gate passed! |
@mrow4a Tests passed, approve? |
Description
Related Issue
Types of changes
Checklist: