-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve login screen #38506
Improve login screen #38506
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
important for brighter backgrounds
One thing to keep in mind (mentioned by @ChrisEdS ): For custom brandings the button color should be included in the styling process. |
@pmaier1 @hurradieweltgehtunter Ok for me to keep the arrow and add the login button. @phil-davis but we need to make sure that we really press the login buttton in the CI |
There's multiple possibilities:
I'd prefer 2) UX wise. Let me know if I should do this change also. |
Beautiful 1 ! @hurradieweltgehtunter encountered a little bug with IE11: |
One more thing: hovering over the -> login arrow button, will now make the item disappear |
@ChrisEdS yould you re-check with errors end customer themes? |
Changes are final, ready to merge. |
@hurradieweltgehtunter Please document how the users/customers can theme the new elements. That should be part of the admin release notes as well. // cc @pmaier1 |
This comment has been minimized.
This comment has been minimized.
@cdamken old version ? invalidate your cache please |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are 50 commits here, and the rebase process was giving me conflicts...
I squashed all the commits into another branch on top of current master - see PR #38821 - we could actually merge the code from that PR with a single clean commit. The changelog link could be left as it is, pointing to this PR, because this PR is where all the discussion and history is.
Description
When the new OIDC / AzureAD Login was presented the old-fashioned grey "Login with AzureAD" button did not represent this modern feature accordingly. Also the missing dedicated Login-Button was bugging me for years.
This PR adds some styling, makes the HTML valid and adds a dedicated login button.
How Has This Been Tested?
Latest Firefox, Latest Chrome, Latest Safari
Screenshots (if appropriate):
Before:
After:
Types of changes
Checklist:
QA