Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save notification url as relative instead of absolute #38639

Merged
merged 4 commits into from
Apr 14, 2021
Merged

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Apr 13, 2021

Description

Previous to this fix, absolute URLs were passed to the notification app.
This could cause some CORS issues, hence we now use relative ones.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@JammingBen JammingBen marked this pull request as ready for review April 13, 2021 13:04
@JammingBen JammingBen changed the title Save notification fed url as relative instead of absolute Save notification url as relative instead of absolute Apr 13, 2021
@JammingBen JammingBen requested review from VicDeo and phil-davis April 13, 2021 13:04
@owncloud owncloud deleted a comment from update-docs bot Apr 13, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes LGTM - exactly the changes that are expected.

@AlexAndBear AlexAndBear requested a review from jvillafanez April 14, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants