Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added excludeAction param #38643

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Apr 16, 2021

Description

Adding excludeActions parameter to fileActions registerDefaultActions

Motivation and Context

Imagine you write your own file list for a specific app, you want you to use all the default actions, but not the 'Rename' action.
Therefore you needed to define all the actions again in the app. This can now be overcome by passing ['Rename'] as excludeActions parameter.

How Has This Been Tested?

Manual UI Testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Apr 16, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear force-pushed the registerDefaultActions-exclude-feature branch from d13443e to 43ffdde Compare April 16, 2021 08:04
apps/files/js/fileactions.js Outdated Show resolved Hide resolved
apps/files/js/fileactions.js Outdated Show resolved Hide resolved
@JammingBen
Copy link
Contributor

@phil-davis any clue why the js tests are failing ?

As mentioned in the review, I assume it's due to includes(). At least we can give it a try 🙂

@AlexAndBear AlexAndBear force-pushed the registerDefaultActions-exclude-feature branch from 43ffdde to c6ac7be Compare April 16, 2021 08:37
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Add a changelog, then it's good to go from my side 🚀

@AlexAndBear AlexAndBear force-pushed the registerDefaultActions-exclude-feature branch from c6ac7be to f136eb1 Compare April 16, 2021 08:59
@AlexAndBear AlexAndBear marked this pull request as ready for review April 16, 2021 08:59
@AlexAndBear
Copy link
Author

@jvillafanez cool with it?

@sonarcloud
Copy link

sonarcloud bot commented Apr 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jvillafanez
Copy link
Member

My only "complain" is that the defaultActions variable seems too big and it makes the function difficult to read. It's a bit easy to lose focus on what the function is doing. Taking into account that we don't plan to add more default actions there, it could be fine since we probably don't want to keep a copy of that variable somewhere else.
Anyway, I'm approving since I don't have better options at the moment.

@AlexAndBear AlexAndBear merged commit d6dfddc into master Apr 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the registerDefaultActions-exclude-feature branch April 16, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants