-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tab headers on small display ratio #38653
Conversation
c3b5659
to
5c04546
Compare
please add changelog |
@micbar done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hovering state of the tabs is wider than the un-hovered state which results in a little sideways glitch when hovering over the tabs.
font:weight: bold;
makes the tab wider.
-> remove font-weight: bold;
or add font-weight: bold
to unhovered state, too
5c04546
to
7653693
Compare
@micbar @hurradieweltgehtunter @ChrisEdS since we refactored the whole tab headers look and feel, I request a new review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Chrome. Looks good to me!
Kudos, SonarCloud Quality Gate passed! |
Description
Fixing tabheader misalign issue on small display ratio, also adjust selected style which is matching better now to other elements (for example left sidebar)
Issue reported by @ChrisEdS
Tested on:
Screenshots (if appropriate):
Before:
After:
(Normal view mode)
(Shrinked view mode)
Types of changes
Checklist: