Skip to content

Adjust permissions for the root folder of the SMB mount #38709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jvillafanez merged 4 commits into from
May 20, 2021
Merged

Adjust permissions for the root folder of the SMB mount #38709

jvillafanez merged 4 commits into from
May 20, 2021

Conversation

@jvillafanez
Copy link
Member

@jvillafanez jvillafanez commented May 7, 2021

Description

Fix permissions for the root folder of the mount point

Related Issue

https://github.com/owncloud/enterprise/issues/4546

Motivation and Context

How Has This Been Tested?

Manually tested. Renaming or deleting the mount point will get a 403 error code

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez self-assigned this May 7, 2021
@owncloud owncloud deleted a comment from update-docs bot May 10, 2021
@jvillafanez jvillafanez force-pushed the smb_mount_permissions branch from c5820ef to d7c9e0b Compare May 18, 2021 15:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

IljaN
IljaN approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@IljaN IljaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvillafanez jvillafanez merged commit 414ece2 into master May 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the smb_mount_permissions branch May 20, 2021 12:03
@jvillafanez jvillafanez mentioned this pull request May 31, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@IljaN IljaN IljaN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jvillafanez jvillafanez

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvillafanez @IljaN