Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mobile UI for files list #38748

Merged
merged 1 commit into from
May 25, 2021
Merged

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented May 19, 2021

Description

This improvement solves the problem that files and folders with a longer name
than 10 chars will cut off to 7 chars by hiding non-essential meta data.
This is unwieldy to navigate through files and folders.
As well the uploading indicator text on a folders table row will now be
displayed at the beginning to avoid UI glitches.

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Before

before

After

after

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear requested a review from ChrisEdS May 19, 2021 08:56
@owncloud owncloud deleted a comment from update-docs bot May 19, 2021
@AlexAndBear AlexAndBear requested a review from pmaier1 May 19, 2021 09:55
@AlexAndBear AlexAndBear self-assigned this May 19, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review May 19, 2021 09:55
@AlexAndBear
Copy link
Author

@pmaier1 cool with it?

@AlexAndBear AlexAndBear force-pushed the improve-filelist-mobile-ui branch 2 times, most recently from 8cd11c8 to 592d754 Compare May 19, 2021 10:18
Copy link
Contributor

@ChrisEdS ChrisEdS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically approved.

apps/files/css/mobile.css Outdated Show resolved Hide resolved
@phil-davis
Copy link
Contributor

Thinking out loud - I wonder what we should do about testing that the webUI "behaves nicely" when being displayed on a smaller device/window? It would be possible to run some CI with a smaller-sized browser window, but we can also just leave it to manual smoke-test to be done during release QA.

@AlexAndBear
Copy link
Author

@phil-davis Do we have similar tests already, how much effort do you think is required for a full coverage?

@phil-davis
Copy link
Contributor

phil-davis commented May 20, 2021

@phil-davis Do we have similar tests already, how much effort do you think is required for a full coverage?

In web we set an env var, for example, "SCREEN_RESOLUTION": "375x812" to test with a mobile-phone-sized screen.

Here in the "traditional" oC10 UI we can do similar. Code like this resizes the window:
$this->getSession()->resizeWindow(375, 812, 'current');

We can add some code to do that if SCREEN_RESOLUTION is set. And then run whatever subset of test scenarios we like in CI with whatever SCREEN_RESOLUTION settings.

The "problem" is that we keep adding more CI pipelines! So maybe we just do it for a set of "smokeTest" scenarios.

I raised issue #38759 for that. Does not need to happen for this PR!

@sonarcloud
Copy link

sonarcloud bot commented May 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlexAndBear
Copy link
Author

@pmaier1 waiting for your go 👍

@pmaier1
Copy link
Contributor

pmaier1 commented May 25, 2021

@pmaier1 waiting for your go

Fine for me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants