-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve mobile UI for files list #38748
Conversation
5ebcfb1
to
2f92766
Compare
8ca08f7
to
ff29cee
Compare
@pmaier1 cool with it? |
8cd11c8
to
592d754
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically approved.
Thinking out loud - I wonder what we should do about testing that the webUI "behaves nicely" when being displayed on a smaller device/window? It would be possible to run some CI with a smaller-sized browser window, but we can also just leave it to manual smoke-test to be done during release QA. |
592d754
to
14e2cf5
Compare
@phil-davis Do we have similar tests already, how much effort do you think is required for a full coverage? |
In web we set an env var, for example, Here in the "traditional" oC10 UI we can do similar. Code like this resizes the window: We can add some code to do that if The "problem" is that we keep adding more CI pipelines! So maybe we just do it for a set of "smokeTest" scenarios. I raised issue #38759 for that. Does not need to happen for this PR! |
Kudos, SonarCloud Quality Gate passed! |
@pmaier1 waiting for your go 👍 |
Fine for me 👍 |
Description
This improvement solves the problem that files and folders with a longer name
than 10 chars will cut off to 7 chars by hiding non-essential meta data.
This is unwieldy to navigate through files and folders.
As well the uploading indicator text on a folders table row will now be
displayed at the beginning to avoid UI glitches.
How Has This Been Tested?
Screenshots (if appropriate):
Before
After
Types of changes
Checklist: