Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement fallback response type for ocm discover #38751

Merged
merged 1 commit into from
May 19, 2021

Conversation

karakayasemi
Copy link
Contributor

Description

Some ocm-provider implementations are slightly different than us. This pr implements fallback for different ocm-provider API responses.

Related Issue

https://github.com/owncloud/enterprise/issues/4522#issuecomment-841884476

Motivation and Context

Prevent unnecesary error logs.

How Has This Been Tested?

Tested federated sharing functionality manually with different ocm providers.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@karakayasemi karakayasemi requested a review from VicDeo May 19, 2021 12:29
@update-docs
Copy link

update-docs bot commented May 19, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@karakayasemi karakayasemi changed the title implement falback response type for ocm discover implement fallback response type for ocm discover May 19, 2021
@karakayasemi karakayasemi force-pushed the implement-ocm-discover-fallback branch from 5b0b3e3 to a91c54c Compare May 19, 2021 12:33
@karakayasemi karakayasemi self-assigned this May 19, 2021
@karakayasemi karakayasemi force-pushed the implement-ocm-discover-fallback branch from a91c54c to 8481014 Compare May 19, 2021 12:42
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@karakayasemi karakayasemi merged commit 08461d8 into master May 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the implement-ocm-discover-fallback branch May 19, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants