Add action to resend the invitation email for a user

[JammingBen]

Description

Resend invitation email
Implemented an action to resend the invitation email for a user that hasnever been logged in yet.

Related Issue

• Fixes https://github.com/owncloud/enterprise/issues/4577

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised: @mmattel required ?
• Changelog item, see TEMPLATE

[AlexAndBear]

@phil-davis @JammingBen acceptance tests needed ?

[phil-davis]

@phil-davis @JammingBen acceptance tests needed ?

We have existing test scenarios like: https://github.com/owncloud/enterprise/issues/4454

  Scenario Outline: user sets his own password after being created with an Email address only
    When the administrator creates a user with the name "<username>" and the email "guiusr1@owncloud" without a password using the webUI
    And the administrator logs out of the webUI
    And the user follows the password set link received by "guiusr1@owncloud" using the webUI
    And the user sets the password to "%regular%" and confirms with the same password using the webUI
    Then the user should be redirected to the login page
    And the email address "guiusr1@owncloud" should have received an email with the body containing
      """
      Password changed successfully
      """
    When the user logs in with username "<username>" and password "%regular%" using the webUI
    Then the user should be redirected to a webUI page with the title "Files - %productname%"
    Examples:
      | username | comment               |
      | guiusr1  | simple user-name      |
      | a@-+_.'b | complicated user-name |

We could add a scenario where the user "forgets" and the email needs to be sent again.

It will need some additions to the page object for the users page, so that the test can find where to click to re-send the email. Who should do that? (I can get someone to look at it tomorrow, if you like)

[JammingBen]

It will need some additions to the page object for the users page, so that the test can find where to click to re-send the email. Who should do that? (I can get someone to look at it tomorrow, if you like)

We take care 👍

[ChrisEdS]

Will this action only be showed when the user was invited via email initially?

[AlexAndBear]

Will this action only be showed when the user was invited via email initially?

Nope, do you expect it to work that way?

[AlexAndBear]

@phil-davis now we also cover, that the first link has an expired/invalid token. Thanks for the hint!

[phil-davis]

LGTM

[jvillafanez]

Maybe a designer should check the icon. It isn't crystal clear to me that you'll send an email. The color is also different from the trashbin icon.

[jvillafanez]

Code looks good

[AlexAndBear]

@jvillafanez the color is different because we in a hover state in the first screen

[AlexAndBear]

• Add title attribute for tooltip
• Make icon look similar to delete

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[mmattel]

Maybe stupid but why not in addition a occ command set where you can trigger to resend an invite to either a named or all never logged in like:

occ resend-invite:list
occ resend-invite:send --all
occ resend-invite:send <name>

[JammingBen]

Maybe stupid but why not in addition a occ command set where you can trigger to resend an invite to either a named or all never logged in like:

I personally find it more intuitive via WebUI. The admin creates users via UI, therefore it makes sense to place this action there, too. These commands could be a nice addition though.

[AlexAndBear]

@mmattel can you point out a real-world use-case for the command?
@pmaier1 is the command included in the 'low effort' schedule ?

[phil-davis]

Note: IMO occ user:add does not currently have the ability to specify just the email address, and have an invitation email sent to the new user. It seems to always want a password. So maybe there are no admins currently using the command line to create users in this way.

[pmaier1]

Thanks. As @phil-davis points out, the action is currently only available via Web UI. Therefore the FR also only applies to Web UI.