-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve external storages settings ui: Show dedicated messages for failed to load mount points / Autofocus available for while adding external mount points #38795
Conversation
3d33fba
to
0901cb9
Compare
0901cb9
to
664e569
Compare
664e569
to
f39c627
Compare
Double-check with multiple mount points. I think that the initial page load triggers an update status for all the mounts, so if there are several wrong mount points the notifications could be piled up. |
f39c627
to
3db715b
Compare
That's intended, customer have about 70 mount points with a large list and wants to be informed about all failing mount points without scrolling trough the list |
My worry is that, if there is a connection problem and all the storages are disconnected, the admin will have 70 notifications in the web UI, and I'm not sure if the UI is ready to handle such amount. It could be fine for 3-5 errors but I think the UI will be bloated if there are more. |
@jvillafanez |
3db715b
to
c703a5c
Compare
373338f
to
4ef37da
Compare
a69fa39
to
2e4eac9
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test changes LGTM and pass.
Description
Enhancement: Improve admin external storage settings UI
Before this PR no error notification was shown while an external mount point configuration was not able to load.
This was only indicated with a red square with a long list of external mount points, this was not handy.
Therefore an error notification will be shown with the dedicated external mount point which fails to load.
As well improved the add external mount point functionality with opening the available for select while adding an external mount point.
The select will have now a 'select all' item.
These changes prevents the admin to expose the mount point
unwanted to all users immediately.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: