New cache state #38804
New cache state #38804
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| $data = $cache->get($internalPath); | ||
| $this->unlockFile($relativePath, ILockingProvider::LOCK_SHARED); | ||
| } elseif ($data['size'] === IScanner::SIZE_SHALLOW_SCANNED) { | ||
| $cache->correctFolderSize($internalPath, $data); |
There was a problem hiding this comment.
Lock shouldn't be needed because we don't hit the storage... should we propagate the change using the propagator?
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
Added input regarding the getIncomplete() method. Other than that it looks good to me, but changelog is missing.
|
This is ready. |
jvillafanez
force-pushed
the
new_cache_state
branch
from
2566ef6 to
e300cbd
Compare
💥 Acceptance tests webUIAddUsers-chrome-mariadb10.2-php7.4 failed. The build is cancelled... |
|
https://drone.owncloud.com/owncloud/core/30591/125/15 |
|
Kudos, SonarCloud Quality Gate passed!
|
Description
Add a new state in the cache to know the folders that have been shallow scanned to avoid re-scanning them
Related Issue
https://github.com/owncloud/enterprise/issues/4594
Motivation and Context
A partial scan implies that a folder might have been scanned on its first level but not deeper. Except for the size, the rest of the information can be reused and there is no need to scan the folder again (if there is no change detected).
This PR improves this scenario and prevents hitting the backend storage if there is no change
How Has This Been Tested?
Checked with an slow external storage
Page will load faster because we won't hit the external storage.
Screenshots (if appropriate):
Types of changes
Checklist: