Skip to content

Adjust position of the autocomplete element #38831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JammingBen merged 2 commits into from
Jun 10, 2021
Merged

Adjust position of the autocomplete element #38831

JammingBen merged 2 commits into from
Jun 10, 2021

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jun 10, 2021 •
edited by AlexAndBear
Loading

We now append the element to #shareTabView to prevent the autocomplete dialog from being hidden in certain scenarios. This happened with Safari for example as soon as the filelist was long enough to have a vertical scrollbar.

Related Issue

Screenshots (if appropriate):

before:

image

after:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from update-docs bot Jun 10, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JammingBen JammingBen merged commit 9fbb05d into master Jun 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-share-autocomplete-position branch June 10, 2021 11:15
@phil-davis phil-davis mentioned this pull request Jun 30, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrow4a mrow4a mrow4a approved these changes

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

+1 more reviewer

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AlexAndBear AlexAndBear

@JammingBen JammingBen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JammingBen @mrow4a @AlexAndBear