-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow public link sharing only for certain groups #38980
Conversation
0a88dcf
to
c9d3444
Compare
TBD:
|
3622089
to
32a5977
Compare
71799de
to
4bb4f22
Compare
d742117
to
5636d61
Compare
What to do about the webUI. If you are not in a group that is allowed to create public links, then you gett all the way through the "Create link share" dialog and are told "User is not in a whitelisted group". We could check this ability when displaying the "Public Links" tab. Where it says "There are currently no link shares, you can create one" and displays the "Create public link" button, that UI could be adjusted to have no button and some different text to explain that the user can't create a public link. |
@phil-davis I don't get it, the Public link tab will be hidden if you are not in a group which is allowed to share |
I just tried it. I enabled this setting and put just the |
@phil-davis should not work this way :/ can you try to force a cache reload ? |
I logged out, then ctrl-F5, logged in again. I still have the same "feature". |
93e3346
to
8276798
Compare
I highly guess that this will change the UI and will therefore be docs relevant... @EParzefall fyi |
@phil-davis whether @JammingBen or I am not able to reproduce it, can you have a look if there are any js errors? @mmattel won't go in 10.8 |
ff48faf
to
88dbca0
Compare
bb91ce9
to
ff1c981
Compare
💥 Acceptance tests pipeline apiFederationToRoot1-latest-mariadb10.2-php7.4 failed. The build has been cancelled. |
💥 Acceptance tests pipeline apiFederationToRoot1-10.6.0-mariadb10.2-php7.4 failed. The build has been cancelled. |
💥 Acceptance tests pipeline apiFederationToRoot1-latest-mariadb10.2-php7.4 failed. The build has been cancelled. |
💥 Acceptance tests pipeline apiFederationToRoot1-10.6.0-mariadb10.2-php7.4 failed. The build has been cancelled. |
💥 Acceptance tests pipeline apiFederationToRoot1-git-mariadb10.2-php7.4 failed. The build has been cancelled. |
cc7b844
to
a179939
Compare
💥 Acceptance tests pipeline apiProxySmoke-8-1-mariadb10.2-php7.4 failed. The build has been cancelled. |
a179939
to
503b25e
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Acceptance tests in CI and manual double-checks of the UI functionality.
Types of changes
Checklist: