Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow public link sharing only for certain groups #38980

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Jul 12, 2021

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Acceptance tests in CI and manual double-checks of the UI functionality.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

@AlexAndBear
Copy link
Author

AlexAndBear commented Jul 12, 2021

TBD:

@owncloud owncloud deleted a comment from update-docs bot Jul 13, 2021
@AlexAndBear AlexAndBear requested a review from micbar July 13, 2021 12:20
@AlexAndBear AlexAndBear force-pushed the enterprise/issues/3632 branch 2 times, most recently from 71799de to 4bb4f22 Compare July 13, 2021 16:35
@owncloud owncloud deleted a comment from ownclouders Jul 13, 2021
@owncloud owncloud deleted a comment from ownclouders Jul 13, 2021
@AlexAndBear AlexAndBear changed the title Enterprise/issues/3632 Allow public link sharing only for certain groups Jul 13, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review July 13, 2021 23:07
@phil-davis
Copy link
Contributor

What to do about the webUI. If you are not in a group that is allowed to create public links, then you gett all the way through the "Create link share" dialog and are told "User is not in a whitelisted group".

We could check this ability when displaying the "Public Links" tab. Where it says "There are currently no link shares, you can create one" and displays the "Create public link" button, that UI could be adjusted to have no button and some different text to explain that the user can't create a public link.

@AlexAndBear
Copy link
Author

@phil-davis I don't get it, the Public link tab will be hidden if you are not in a group which is allowed to share

@phil-davis
Copy link
Contributor

phil-davis commented Jul 14, 2021

@phil-davis I don't get it, the Public link tab will be hidden if you are not in a group which is allowed to share

I just tried it. I enabled this setting and put just the admin group in the list. Then I logged in as an ordinary user (not in admin group). When I go to share a folder, I see the Public Links tab and can try to create a public link:
Screenshot from 2021-07-14 11-20-03

@AlexAndBear
Copy link
Author

@phil-davis should not work this way :/ can you try to force a cache reload ?

@phil-davis
Copy link
Contributor

@phil-davis should not work this way :/ can you try to force a cache reload ?

I logged out, then ctrl-F5, logged in again. I still have the same "feature".

.htaccess Outdated Show resolved Hide resolved
@mmattel
Copy link
Contributor

mmattel commented Jul 14, 2021

I highly guess that this will change the UI and will therefore be docs relevant...
In case I am right, pls file a docs issue so we can track this properly and create a docs PR when this here gets merged. Also tell if this will go into 10.8

@EParzefall fyi

@AlexAndBear
Copy link
Author

AlexAndBear commented Jul 14, 2021

@phil-davis whether @JammingBen or I am not able to reproduce it, can you have a look if there are any js errors?

@mmattel won't go in 10.8

@owncloud owncloud deleted a comment from ownclouders Jul 16, 2021
@owncloud owncloud deleted a comment from ownclouders Jul 16, 2021
@owncloud owncloud deleted a comment from ownclouders Jul 16, 2021
.htaccess Outdated Show resolved Hide resolved
@owncloud owncloud deleted a comment from ownclouders Jul 20, 2021
@owncloud owncloud deleted a comment from ownclouders Jul 20, 2021
@owncloud owncloud deleted a comment from ownclouders Jul 20, 2021
@owncloud owncloud deleted a comment from ownclouders Jul 20, 2021
@owncloud owncloud deleted a comment from ownclouders Jul 20, 2021
@owncloud owncloud deleted a comment from ownclouders Jul 20, 2021
@owncloud owncloud deleted a comment from ownclouders Jul 20, 2021
@owncloud owncloud deleted a comment from ownclouders Jul 20, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot1-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31386/108/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot1-10.6.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31399/109/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot1-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31403/108/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot1-10.6.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31404/109/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot1-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31404/107/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31417/171/1

@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

72.7% 72.7% Coverage
0.0% 0.0% Duplication

Copy link

@michaelstingl michaelstingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current versions of desktop, iOS and Android Apps provide clear user feedback:

CleanShot 2021-07-22 at 09 52 09@2x Screenshot_20210722-111011 IMG_0031

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexAndBear AlexAndBear merged commit 9789311 into master Jul 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the enterprise/issues/3632 branch July 23, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants