Do not allow empty system or app config key #38996
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently this sort of thing works:
The app name and config key should not be able to be the empty string. There is never a need to have an app named "" or a key "". This had somehow happened in one developers install, and caused issues when trying to get the config settings.
This PR disallows using an app name or config key that is the empty string. That will avoid accidentally making such settings.
I did not change the corresponding
config:delete
commands - if someone does somehow have one of these "empty string" set, they need to be able to delete it.How Has This Been Tested?
CI
Types of changes
Checklist: