Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logo sizing #39129

Merged
merged 1 commit into from
Aug 24, 2021
Merged

fix logo sizing #39129

merged 1 commit into from
Aug 24, 2021

Conversation

hurradieweltgehtunter
Copy link
Contributor

@hurradieweltgehtunter hurradieweltgehtunter commented Aug 23, 2021 •
edited
Loading

Description

In some cases the previously fixed logo size resulted in a cut off logo. This PR sets the logo size dynamically.

Screenshots (if appropriate):

Before
grafik

After
grafik

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Aug 23, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 23, 2021
ChrisEdS
ChrisEdS approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@ChrisEdS ChrisEdS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/core/31940/156/9
yarn-install hung for 3 hours! Stupid drone agent. I restarted.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hurradieweltgehtunter hurradieweltgehtunter merged commit b2b7fc8 into master Aug 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-login-logo branch August 24, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisEdS ChrisEdS ChrisEdS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hurradieweltgehtunter @phil-davis @ChrisEdS