Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image orientation method #39140

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Fix image orientation method #39140

merged 2 commits into from
Aug 30, 2021

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Aug 27, 2021

Description

Fixes an issue where exif information of images was not processed properly on file- and avatar-uploads. This only works when loading files via path or handle. Before we mostly loaded images via content.

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIAddUsers-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31981/130/1

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

79.2% 79.2% Coverage
0.0% 0.0% Duplication

@owncloud owncloud deleted a comment from update-docs bot Aug 30, 2021
@JammingBen JammingBen marked this pull request as ready for review August 30, 2021 07:48
@IljaN IljaN self-requested a review August 30, 2021 08:44
@JammingBen JammingBen merged commit 8ba900e into master Aug 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-image-orientation branch August 30, 2021 14:22
@jnweiger
Copy link
Contributor

jnweiger commented Dec 1, 2021

Confirmed fixed in 10.9.0 beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect image orientation since 10.8
4 participants