Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-user folders in command occ:user report #39223

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Sep 13, 2021

Description

Bugfix: don't count non-user folder in occ user:report command

Before this PR several folders, for example 'avatars', have been counted as user
folders via the occ user:report command.
With this PR a list of folders has been added which should not be counted as user folders.
The user directory count is now correct.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear force-pushed the occ-user-report-dont-count-non-user-dirs-2 branch from 40e30e8 to 1bdc964 Compare September 13, 2021 12:12
@AlexAndBear
Copy link
Author

FYI @NannaBarz @pmaier1

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear marked this pull request as ready for review September 13, 2021 13:26
@AlexAndBear AlexAndBear merged commit 17e929a into master Sep 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the occ-user-report-dont-count-non-user-dirs-2 branch September 13, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants