Skip to content

Add option to hide the upload estimation in WebUI#39228

Merged
phil-davis merged 3 commits intomasterfrom
enterprise/issues/4743
Sep 14, 2021
Merged

Add option to hide the upload estimation in WebUI#39228
phil-davis merged 3 commits intomasterfrom
enterprise/issues/4743

Conversation

@JammingBen
Copy link
Contributor

Description

The upload estimation can now be hidden when setting hide_upload_estimation to "yes" via occ command.

Related Issue

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear requested review from phil-davis and removed request for phil-davis September 14, 2021 10:36
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@phil-davis
Copy link
Contributor

Note: there are not automated acceptance tests for this sort of thing, because the progress bar is very timing-dependent, and tests might or might not "see" what is happening in the progress bar, depending on if the test runner and/or system-under-test are running on fast or slow systems.

@AlexAndBear
Copy link

Docs relevant,

please file a docs issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@phil-davis
Copy link
Contributor

Docs relevant,

please file a docs issue.

owncloud/docs#4034

@phil-davis phil-davis merged commit bace78c into master Sep 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the enterprise/issues/4743 branch September 14, 2021 11:45
@ghost
Copy link

ghost commented Dec 7, 2021

works. For the future: Please write the complete occ command in the description. It would save us a lot of testing time if we had the command directly and didn't have to search for it and assemble it. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants