Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buttons and icons for file list actions without text in mobile view #39233

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Sep 15, 2021

Description

Enhancement: Use icons + buttons instead of text for file actions in mobile view

Before this PR, as files were selected in the files list, actions was shown with
icon and text, for example: 'Download' and 'Delete'.
This uses much space and UI glitches are possible due to limited screen size.
With this PR we now show buttons with the associated icons without any text.

Screenshots (if appropriate):

Files - Before

image

Files - After

image

Deleted files - Before

image

Deleted files - After

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear force-pushed the file-list-mobile-view-header-use-icons branch from fa37bbd to d5d5bb7 Compare September 15, 2021 08:07
@AlexAndBear AlexAndBear changed the title Use buttons and icons instead of texts Use buttons and icons for file list actions without text in mobile view Sep 15, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review September 15, 2021 08:08
@AlexAndBear AlexAndBear self-assigned this Sep 15, 2021
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@AlexAndBear
Copy link
Author

AlexAndBear commented Sep 15, 2021

@pmaier1 agree?

@phil-davis
Copy link
Contributor

As a separate thing, the "..." dropdown also shows each action with icon and text:
webUI-mobile-size-dropdown

Should we remove the text from those?
(I am not sure of the answer myself)

@AlexAndBear
Copy link
Author

AlexAndBear commented Sep 15, 2021

@phil-davis we should just shrink items, which takes too much space and conflicts with other elements.
So i vote for everything cool here 👍

Moreover the ... menu should be full width in mobile view, from my POV

Note: I am taking care of the restore text in deleted files in another PR

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit d32cccd into master Sep 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the file-list-mobile-view-header-use-icons branch September 15, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants