Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide restore text in fileList for deleted files mobile #39236

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Hide restore text in fileList for deleted files mobile #39236

merged 2 commits into from
Sep 15, 2021

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Sep 15, 2021 •
edited
Loading

Description

Enhancement: Hide restore text in deleted files list on mobile device

With this PR restore text next to the associated icon will be hidden to
grant space for the file and folder names.

Screenshots (if appropriate):

Before

image

After

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear self-assigned this Sep 15, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review September 15, 2021 08:59
@owncloud owncloud deleted a comment from update-docs bot Sep 15, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

phil-davis
phil-davis approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@AlexAndBear AlexAndBear merged commit ae7e87d into master Sep 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the file-list-deleted-files-hide-restore-text-mobile branch September 15, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@JammingBen JammingBen JammingBen approved these changes

Assignees

@AlexAndBear AlexAndBear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @phil-davis @JammingBen