Fix issue restoring versions from the trashbin after sharing #39822

jvillafanez · 2022-02-22T13:23:01Z

A folder contains a file with multiple versions. The folder is shared
with another user. That user deletes the shared file (with the
versions). Then, that user restores the file. At that point, the
versions were broken due to a bad signature.

Description

According to docs, versions are copied as such, so the signature in the file doesn't change. Since the signature doesn't change, the "encrypted" column shouldn't change neither.
Even if we're moving versions, we won't increase the "encrypted" value for the version in order to not disrupt the signature in the file.

Related Issue

#39664

Motivation and Context

Versions of the file were broken after following the steps described in the issue

How Has This Been Tested?

Manually tested following the steps

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

update-docs · 2022-02-22T13:23:05Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

lib/private/Files/Storage/Wrapper/Encryption.php

A folder contains a file with multiple versions. The folder is shared with another user. That user deletes the shared file (with the versions). Then, that user restores the file. At that point, the versions were broken due to a bad signature.