Prevent stored mail settings password from get shown in the ui

[AlexAndBear]

Description

Security: Prevent stored mail settings password from showing in the webUI

Related Issue

• Fixes issues/5035

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[ownclouders]

💥 Acceptance tests pipeline apiFederationToRoot1-10.8.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34764/104/1

[ownclouders]

💥 Acceptance tests pipeline webUIManageQuota-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34764/132/1

[ownclouders]

💥 Acceptance tests pipeline webUISharingPublic2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34764/148/1

[phil-davis]

I added a UI test scenario that sets those mail credentials, reloads the page, checks that they are set in config.php, but that the mail credentials password is not sent back to the UI. It fails on current master and passes with the code in this PR.

[phil-davis]

LGTM - works

[AlexAndBear]

@phil-davis THX, unfortunately, I re-requested your review

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication