Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent stored mail settings password from get shown in the ui #39833

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Prevent stored mail settings password from get shown in the ui #39833

merged 3 commits into from
Feb 28, 2022

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Feb 28, 2022 •
edited
Loading

Description

Security: Prevent stored mail settings password from showing in the webUI

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from update-docs bot Feb 28, 2022
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot1-10.8.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34764/104/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIManageQuota-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34764/132/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUISharingPublic2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34764/148/1

@phil-davis
Copy link
Contributor

I added a UI test scenario that sets those mail credentials, reloads the page, checks that they are set in config.php, but that the mail credentials password is not sent back to the UI. It fails on current master and passes with the code in this PR.

phil-davis
phil-davis reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - works

@AlexAndBear
Copy link
Author

AlexAndBear commented Feb 28, 2022 •
edited
Loading

@phil-davis THX, unfortunately, I re-requested your review

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit e59b109 into master Feb 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/5035 branch February 28, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @ownclouders @phil-davis