Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve FileDrop view #39900

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Improve FileDrop view #39900

merged 1 commit into from
Mar 21, 2022

Conversation

ChrisEdS
Copy link
Contributor

@ChrisEdS ChrisEdS commented Mar 18, 2022 •
edited
Loading

Description

Small change in the design and behavior of the FileDrop view of Public Links.

  • The font is bigger and thicker
  • Background color was added to the list of files
  • The text in the "Dropbox" is wrapped properly, line-height was removed
  • Don't hide the logo on small resolutions

Related Issue

Motivation and Context

You should see immediately that something has changed in the UI after the first file is completely uploaded so that you are not tempted to upload files twice.

How Has This Been Tested?

  • Manually tested in Chrome and Firefox
  • ...

Screenshots:

Before:

Screenshot 2022-03-18 at 13 41 54

After:

image

On small resolution:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ChrisEdS ChrisEdS self-assigned this Mar 18, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Mar 18, 2022 •
edited
Loading

💥 Acceptance tests pipeline webUIFileActionsMenu-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34994/158

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareOperationsToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34978/68

AlexAndBear
AlexAndBear approved these changes Mar 18, 2022
View reviewed changes
apps/files_sharing/js/PublicUploadView.js Outdated Show resolved Hide resolved
@ChrisEdS ChrisEdS force-pushed the filedrop-enhancement branch 5 times, most recently from a756430 to 8a4161b Compare March 19, 2022 02:06
@ChrisEdS
Improve FileDrop view
df433be 
Add changelog entry

Fix CSS style

Giving the <ul> a border top and bottom instead of having an <hr>

Add original content from PublicUploadView.js

Don't hide the logo on small resolutions

Update changelog

Background color was added to the list of files instead of dotted lines

Update changelog

Adjust the padding inside the dropzone

Change gradient style
@sonarcloud
Copy link

sonarcloud bot commented Mar 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@owncloud owncloud deleted a comment from update-docs bot Mar 21, 2022
phil-davis
phil-davis approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@phil-davis phil-davis merged commit 48c8ca3 into master Mar 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the filedrop-enhancement branch March 21, 2022 03:50
@tbsbdr
Copy link

tbsbdr commented Mar 21, 2022

uha, nice :-)
if you ask for further improvement, you could also add:

  • communicate the uploaded files more as a succes, eg. by adding checkmarks to them ✅
  • within the drop-zone, add a very short headline above the instructional line, eg. "Upload"

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@ChrisEdS ChrisEdS

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uploaded content to FileDrop folder is hard to see
5 participants
@ChrisEdS @ownclouders @tbsbdr @phil-davis @AlexAndBear