Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit share with user type #40013

Merged
merged 7 commits into from
Apr 25, 2022
Merged

Emit share with user type #40013

merged 7 commits into from
Apr 25, 2022

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Apr 25, 2022 •
edited
Loading

Description

Enhancement: Expose user type of share receiver in share api

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

@AlexAndBear AlexAndBear marked this pull request as ready for review April 25, 2022 09:32
@AlexAndBear AlexAndBear mentioned this pull request Apr 25, 2022
Closed
@owncloud owncloud deleted a comment from update-docs bot Apr 25, 2022
@AlexAndBear AlexAndBear force-pushed the share-api-emit-share-with-user-type branch from 6bbdca2 to 33a83a0 Compare April 25, 2022 10:01
@AlexAndBear AlexAndBear mentioned this pull request Apr 25, 2022
Open
12 tasks
phil-davis
phil-davis approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I added share_with_user_type to 2 acceptance test scenarios to make sure that it really shows up.

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 3efa63c into master Apr 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the share-api-emit-share-with-user-type branch April 25, 2022 13:27
This was referenced Apr 29, 2022
Open
Merged
@jesmrec jesmrec mentioned this pull request May 12, 2022
Open
@jnweiger
Copy link
Contributor

Confirmed fixed in 10.10.0 RC2

/ocs/v1.php/apps/files_sharing/api/v1/shares?format=json has

  • normal users shares: share_type=0, share_with_user_type=0
  • guest users shares: share_type=0, share_with_user_type=1
  • group shares: share_type=1 and no element share_with_user_type

share_with_user_type_string was not added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@phil-davis phil-davis phil-davis approved these changes

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexAndBear @jnweiger @jvillafanez @phil-davis @kulmann