-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default for propfind depth infinity should be false as in the past #40016
Conversation
d2caa6e
to
6b9ee22
Compare
💥 Acceptance tests pipeline apiComments-mariadb10.2-php7.4 failed. The build has been cancelled. |
Hooking myself in to get notified when merged so we can start a |
Note: I am working on the acceptance tests in PR #40021 so that I don't make a mess of this PR. I will first get them passing, then sort out adding a few scenarios to test: |
The solution itself looks good, but I think we should clarify the doc in the config.sample |
6b9ee22
to
e7c59af
Compare
@phil-davis I think we should first have this change and then add acceptance on this basis. |
agree - we just need to do the minimal change to the acceptance tests so that the current tests pass. I will keep working on that in #40021 |
64ba86b
to
47a651c
Compare
I rebased and pushed the test changes from #40021 IMO CI should pass and we can merge. |
Kudos, SonarCloud Quality Gate passed! |
Change in https://github.com/owncloud/core/pull/38583/files#diff-efe547293d3c10c67f8014fd439977f1c8f1073dcb65a1a83dc33e7d266dec70R48 release for oc10.9 set dav.propfind.depth_infinity' => true as default and caused some performance issues on some setups. This PR brings back the default as in the past, as discussed in #38583 (comment).
fixes https://github.com/owncloud/enterprise/issues/5154