Use the same string in the header also in public view#40032
Merged
phil-davis merged 2 commits intomasterfrom May 4, 2022
Merged
Use the same string in the header also in public view#40032phil-davis merged 2 commits intomasterfrom
phil-davis merged 2 commits intomasterfrom
Conversation
ChrisEdS
force-pushed
the
sync-header-string
branch
from
70f5403 to
071d931
Compare
Contributor
|
drone CI hung in some pipelines. I cancelled it and restarted it. |
JammingBen
previously requested changes
May 3, 2022
Contributor
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
LGTM, minor typo in the changelog item though
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
Confirmed fixed in 10.10.0 RC2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the public view, a different string was used next to the logo than in the internal header. This can cause problems with branding.
Motivation and Context
The string
HTMLNameis now only used for the header.Nameis used exclusively for the mail templates.How Has This Been Tested?
Types of changes
Checklist: