Add config lang

[AlexAndBear]

Description

Requirement for:
owncloud/web#6243

Related Issue

• Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[jvillafanez]

The idea looks ok to me.

Do we have any plans for adding more information in the "config" key? Otherwise, it seems better to use the "language" key directly.
In addition, should we include the default configured language if the user hasn't configured anything? or maybe include the default in a different key?

[phil-davis]

In addition, should we include the default configured language if the user hasn't configured anything? or maybe include the default in a different key?

The code could return the "effective" language for the user. If the user has explicitly set a language, then return that. If the user has not set a language then return the system default language (which is the language that the user is going to be shown when they log in). There must already be a function somewhere for getEffectiveLanguage

[phil-davis]

get default system lang if not user specified

works

[ownclouders]

💥 Acceptance tests pipeline apiWebdavProperties2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/35799/99

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

50.0% Coverage
0.0% Duplication

[kulmann]

😍

[kulmann]

The code could return the "effective" language for the user. If the user has explicitly set a language, then return that. If the user has not set a language then return the system default language (which is the language that the user is going to be shown when they log in). There must already be a function somewhere for getEffectiveLanguage

Fully agree, clients don't/shouldn't know or care where the language key comes from. They only need a value. The chain of fallbacks as proposed and implemented is perfect. 👍 (user choice -> system default -> hardcoded "en")